Skip to content

CHIA-3779 Make sure the costs and fees match when a peer notifies us of a new transaction that we saw already #20140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

CHIA-3779 Make sure the costs and fees match when a peer notifies us of a new transaction that we saw already #20140

merged 1 commit into from
Oct 17, 2025

Conversation

AmineKhaldi
Copy link
Contributor

@AmineKhaldi AmineKhaldi commented Oct 8, 2025 •
edited
Loading

Purpose:

When a peer notifies us of a new transaction, and we find out that we saw it already, make sure the advertised costs and fees match what we've seen.

Current Behavior:

New Behavior:

Testing Notes:

@AmineKhaldi AmineKhaldi self-assigned this Oct 8, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Oct 8, 2025
@trgarrett
Copy link

Nice!

arvidn
arvidn reviewed Oct 15, 2025
View reviewed changes
@AmineKhaldi AmineKhaldi force-pushed the check_cost_already_seen_new_tx branch from f6a540d to d8b8671 Compare October 16, 2025 10:55
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Oct 16, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18566788769

Details

  • 37 of 37 (100.0%) changed or added relevant lines in 2 files are covered.
  • 41 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.804%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node.py 1 87.08%
chia/_tests/simulation/test_simulation.py 1 96.47%
chia/timelord/timelord_api.py 1 93.02%
chia/consensus/blockchain.py 2 94.38%
chia/server/server.py 3 84.96%
chia/_tests/util/full_sync.py 3 88.14%
chia/server/address_manager.py 9 92.58%
chia/server/node_discovery.py 21 77.1%
Totals Coverage Status
Change from base Build 18544726493: -0.02%
Covered Lines: 102263
Relevant Lines: 112460
💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review October 16, 2025 13:59
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner October 16, 2025 13:59
@AmineKhaldi AmineKhaldi changed the title CHIA-3779 Make sure the costs match when a peer notifies us of a new transaction that we saw already CHIA-3779 Make sure the costs and fees match when a peer notifies us of a new transaction that we saw already Oct 16, 2025
arvidn
arvidn reviewed Oct 16, 2025
View reviewed changes
@AmineKhaldi AmineKhaldi force-pushed the check_cost_already_seen_new_tx branch from d8b8671 to ae9d34b Compare October 16, 2025 15:39
@AmineKhaldi AmineKhaldi requested a review from arvidn October 17, 2025 09:58
@pmaslana pmaslana merged commit 480a060 into Chia-Network:main Oct 17, 2025
401 of 402 checks passed
AmineKhaldi added a commit to AmineKhaldi/chia-blockchain that referenced this pull request Oct 20, 2025
@AmineKhaldi
CHIA-3779 Make sure the costs and fees match when a peer notifies us …
1dfde01 
…of a new transaction that we saw already (Chia-Network#20140)
@AmineKhaldi AmineKhaldi mentioned this pull request Oct 20, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arvidn arvidn arvidn approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AmineKhaldi @trgarrett @arvidn @pmaslana